Skip to content

fix: evm tx index and log indexes are not patched#812

Open
mmsqe wants to merge 29 commits intocosmos:mainfrom
mmsqe:patch
Open

fix: evm tx index and log indexes are not patched#812
mmsqe wants to merge 29 commits intocosmos:mainfrom
mmsqe:patch

Conversation

@mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Nov 7, 2025

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

@mmsqe mmsqe marked this pull request as ready for review November 7, 2025 02:09
@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

❌ Patch coverage is 73.23944% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.52%. Comparing base (43a1f17) to head (a996d11).

Files with missing lines Patch % Lines
x/vm/types/response.go 84.00% 4 Missing and 4 partials ⚠️
rpc/backend/comet_to_eth.go 0.00% 4 Missing and 1 partial ⚠️
rpc/backend/tx_info.go 0.00% 4 Missing ⚠️
rpc/backend/utils.go 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #812      +/-   ##
==========================================
+ Coverage   65.45%   65.52%   +0.07%     
==========================================
  Files         331      331              
  Lines       23262    23304      +42     
==========================================
+ Hits        15225    15271      +46     
+ Misses       6894     6887       -7     
- Partials     1143     1146       +3     
Files with missing lines Coverage Δ
ante/evm/mono_decorator.go 75.00% <ø> (-0.20%) ⬇️
rpc/types/events.go 77.98% <100.00%> (+0.41%) ⬆️
x/vm/keeper/abci.go 91.30% <ø> (-0.37%) ⬇️
x/vm/keeper/config.go 94.11% <100.00%> (ø)
x/vm/keeper/keeper.go 85.92% <ø> (+<0.01%) ⬆️
x/vm/keeper/state_transition.go 85.45% <ø> (-0.05%) ⬇️
rpc/backend/utils.go 55.89% <75.00%> (+0.81%) ⬆️
rpc/backend/tx_info.go 53.69% <0.00%> (+0.75%) ⬆️
rpc/backend/comet_to_eth.go 79.34% <0.00%> (-2.22%) ⬇️
x/vm/types/response.go 84.00% <84.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

* align patch
* cleanup
@aljo242
Copy link
Contributor

aljo242 commented Nov 7, 2025

thanks for opening this @mmsqe - could you give some more context on these changes?

@mmsqe
Copy link
Collaborator Author

mmsqe commented Nov 7, 2025

thanks for opening this @mmsqe - could you give some more context on these changes?

yes, the remove of transient store and EmitTxHashEvent is mentioned in the origin context for parallel tx execution.

@vladjdk
Copy link
Member

vladjdk commented Dec 18, 2025

@mmsqe there are some conflicts and tests failing

@aljo242
Copy link
Contributor

aljo242 commented Jan 6, 2026

@mmsqe conflicts here

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs.

@mmsqe mmsqe requested a review from aljo242 March 9, 2026 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants